Lover makes soldier lament no end (8)
I believe the answer is:
paramour
'lover' is the definition.
(paramour is a kind of lover)
'soldier lament no end' is the wordplay.
'soldier' becomes 'para' (para is a kind of soldier).
'lament' becomes 'mourn' (I've seen this before).
'no end' means to remove the last letter.
'mourn' with its final letter taken off is 'mour'.
'para'+'mour'='PARAMOUR'
'makes' is the link.
(Other definitions for paramour that I've seen before include "Kept woman" , "courtesan" , "wife's toy boy, for example" , "A lover, illicit perhaps" , "Lover, usually illicit" .)