Optical toy that produces constantly changing patterns (12)
I believe the answer is:
kaleidoscope
(Other definitions for kaleidoscope that I've seen before include "Optical pattern-making toy" , "Constantly changing pattern" , "Toy making coloured patterns" , "poodle is plastered with cake" , "A changing pattern of colours, shapes" .)