Something good which also has disadvantages (5,8)
I believe the answer is:
mixed blessing
(Other definitions for mixed blessing that I've seen before include "Event with cons as well as pros" , "It has good and bad points" , "something that has pros and cons?" , "Something with both advantages and disadvantages" , "Event or situation having advantages and disadvantages" .)