A good sort but certainly not brilliant (5,7)
I believe the answer is:
rough diamond
'a good sort' is the definition.
(thesaurus)
I don't understand the rest of the clue.
Can you help me to learn more?
(Other definitions for rough diamond that I've seen before include "a trump, but low" , "Geezer" , "Good but uneducated person" , "Unsophisticated chap - uncut stone" , "Good guy with uncouth manner" .)