Officer in prison on ship has a bumpy ride (9)
I believe the answer is:
brigadier
'officer in prison' is the definition.
'brigadier' can be an answer for 'officer' (brigadier is a kind of officer). I'm unsure of the 'in prison' bit.
'ship has a bumpy ride' is the wordplay.
'ship' becomes 'brig' (I've seen this before).
'has' is a charade indicator (letters next to each other).
'bumpy' indicates an anagram (letters get bumped around).
'ride' is an anagram of 'dier'.
'brig'+'a'+'dier'='BRIGADIER'
'on' is the link.
Can you help me to learn more?
(Other definitions for brigadier that I've seen before include "High-ranking army officer" , "Officer in charge of army unit, part of division" , "Rank above colonel" , "Air bridge over to the military officer" , "Army rank" .)