Swineherd always seen in celebration? (8)
I believe the answer is:
hogmanay
'celebration?' is the definition.
(I've seen this before)
'swineherd always' is the wordplay.
'swineherd' becomes 'hogman' (I can't explain this - if you can you should believe this answer much more).
'always' becomes 'ay' (archaic term for 'always').
'hogman'+'ay'='HOGMANAY'
'seen in' acts as a link.
Can you help me to learn more?
(Other definitions for hogmanay that I've seen before include "Scottish New Year's Eve" , "Annual celebration" , "Festival" , "New Year up north" , "New Year's Eve (Scots)" .)